generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add cloud provider info to the gateways #1778
Merged
hisarbalik
merged 42 commits into
kyma-project:main
from
hisarbalik:add-metricpipeline-cloud-provider-attributes
Feb 3, 2025
Merged
feat: Add cloud provider info to the gateways #1778
hisarbalik
merged 42 commits into
kyma-project:main
from
hisarbalik:add-metricpipeline-cloud-provider-attributes
Feb 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hisarbalik
added
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
and removed
cla: yes
Indicates the PR's author has signed the CLA.
labels
Jan 21, 2025
kyma-bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Jan 21, 2025
kyma-bot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Jan 22, 2025
hisarbalik
added
kind/feature
Categorizes issue or PR as related to a new feature.
area/tests
Writing/adding/Refactoring tests or checks
area/logs
LogPipeline
area/metrics
MetricPipeline
area/traces
TracePipeline
area/manager
Manager or module changes
labels
Jan 22, 2025
a-thaler
reviewed
Jan 27, 2025
a-thaler
reviewed
Jan 27, 2025
….com:hisarbalik/telemetry-manager into add-metricpipeline-cloud-provider-attributes
….com:hisarbalik/telemetry-manager into add-metricpipeline-cloud-provider-attributes
rakesh-garimella
approved these changes
Jan 31, 2025
grego952
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/logs
LogPipeline
area/manager
Manager or module changes
area/metrics
MetricPipeline
area/tests
Writing/adding/Refactoring tests or checks
area/traces
TracePipeline
cla: yes
Indicates the PR's author has signed the CLA.
kind/feature
Categorizes issue or PR as related to a new feature.
lgtm
Looks good to me!
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request (what was done and why):
k8sattribute
processor of gateways (metric, trace, and log) to enrich telemetry data withcloud.availability_zone
,cloud.region
,host.arch
, andhost.type
from well-known kubernetes labels of nodesresource
processorinsert-cluster-attributes
of gateways (metric, trace, and log) to enrich telemetry data withk8s.cluster.name
andcloud.provider
. The data of both were retrieved from custom ConfigMapshoot-info
of gardener clusters, for other runtimes, the attributecloud.provider
ignored, and the value of attributek8s.cluster.name
fall-back to the API-Server URLopenstack
is used to represent theSAP Converged Cloud
provider, the value will besap-converged-cloud
.Changes refer to particular issues, PRs or documents:
Traceability
Related Issues
section.